The following document contains the results of FindBugs Report
FindBugs Version is 2.0.1
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in net.sf.webphotos.WebPhotos.main(String[]): new java.io.PrintWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 62 | High |
exceptional return value of java.io.File.delete() ignored in net.sf.webphotos.WebPhotos.main(String[]) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 49 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Write to static field net.sf.webphotos.action.AcaoAdicionarFoto.diretorioInicial from instance method new net.sf.webphotos.action.AcaoAdicionarFoto(JTable, JComboBox, String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 59 | Medium |
Write to static field net.sf.webphotos.action.AcaoAdicionarFoto.diretorioInicial from instance method net.sf.webphotos.action.AcaoAdicionarFoto.actionPerformed(ActionEvent) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 117 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in net.sf.webphotos.action.AcaoAlterarAlbum.prepareExtraFiles(Album, String): new java.io.FileWriter(String) | I18N | DM_DEFAULT_ENCODING | 248 | High |
Found reliance on default encoding in net.sf.webphotos.action.AcaoAlterarAlbum.prepareExtraFiles(Album, String): new java.io.FileWriter(String) | I18N | DM_DEFAULT_ENCODING | 253 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
net.sf.webphotos.action.AcaoExcluirAlbum.actionPerformed(ActionEvent) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 79 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in net.sf.webphotos.action.AcaoExcluirFoto.actionPerformed(ActionEvent): new java.io.FileWriter(String) | I18N | DM_DEFAULT_ENCODING | 155 | High |
net.sf.webphotos.action.AcaoExcluirFoto.actionPerformed(ActionEvent) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 155 | Medium |
net.sf.webphotos.action.AcaoExcluirFoto.actionPerformed(ActionEvent) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 104 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Nullcheck of f at line 1215 of value previously dereferenced in net.sf.webphotos.gui.PainelWebFotos.carregaFoto() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 1206 | High |
net.sf.webphotos.gui.PainelWebFotos.atualizaAlbum() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 1146 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.controlarAlteracoes from instance method net.sf.webphotos.gui.PainelWebFotos.carregaAlbum() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 1169 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.btAdicionarFotos from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 171 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.btAlterar from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 172 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.btDownload from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 170 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.btFTP from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 168 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.btNovo from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 173 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.btUpload from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 169 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.buttonAddCategory from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 149 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.buttonAddCredits from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 163 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.lblAlbum from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 145 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.lblCategoria from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 147 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.lblData from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 150 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.lblDescricao from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 152 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.lblLegenda from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 159 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.lblTabelaInfo from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 142 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.lstCategoriasAlbum from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 148 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.lstCreditos from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 162 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.lstCreditosTabelaFotos from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 122 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.menuAlbum from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 129 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.menuFoto from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 123 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.menuItemAlbumDelete from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 137 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.menuItemAlbumDown from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 134 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.menuItemAlbumRedoJS from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 131 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.menuItemAlbumRedoThumbs from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 136 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.menuItemAlbumRedoXML from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 130 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.menuItemAlbumUp from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 133 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.menuItemFotoDelete from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 128 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.menuItemFotoDown from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 125 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.menuItemFotoRedoThumbs from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 127 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.menuItemFotoUp from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 124 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.menuSeparadorAlbum1 from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 132 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.menuSeparadorAlbum2 from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 135 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.menuSeparadorFoto from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 126 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.painelAlbuns from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 139 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.painelControle from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 164 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.painelDadosAlbum from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 143 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.painelFormFoto from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 157 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.painelFoto from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 158 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.painelInfoAlbum from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 144 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.painelPesquisa from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 138 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.painelToolBar from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 167 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.scrAlbuns from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 140 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.scrDescricao from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 153 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.scrFotos from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 155 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.scrLegenda from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 160 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.scrLog from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 165 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.tbAlbuns from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 141 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.tbFotos from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 156 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.txtData from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 151 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.txtDescricao from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 154 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.txtLegenda from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 161 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.txtLog from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 166 | Medium |
Write to static field net.sf.webphotos.gui.PainelWebFotos.txtTitulo from instance method net.sf.webphotos.gui.PainelWebFotos.initComponents() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 146 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in net.sf.webphotos.gui.PainelWebFotos$15.doInBackground(): new java.io.FileWriter(String) | I18N | DM_DEFAULT_ENCODING | 621 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in net.sf.webphotos.gui.PainelWebFotos$16.doInBackground(): new java.io.FileWriter(String) | I18N | DM_DEFAULT_ENCODING | 664 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
net.sf.webphotos.gui.component.BotaoIcone.botaoPersonalizado isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 49 | Medium |
net.sf.webphotos.gui.component.BotaoIcone.getIconPrefix() is unsynchronized, net.sf.webphotos.gui.component.BotaoIcone.setIconPrefix(String) is synchronized | MT_CORRECTNESS | UG_SYNC_SET_UNSYNC_GET | 91 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in net.sf.webphotos.gui.component.BotaoIconeBeanInfo.getMdescriptor() | STYLE | REC_CATCH_EXCEPTION | 803 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to fotoMaior in net.sf.webphotos.gui.component.PainelFoto.lblPainelFotoMouseClicked(MouseEvent) | STYLE | DLS_DEAD_LOCAL_STORE | 97 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in net.sf.webphotos.gui.component.PainelFotoBeanInfo.getMdescriptor() | STYLE | REC_CATCH_EXCEPTION | 732 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
net.sf.webphotos.gui.component.PainelPesquisa.getAcaoPesquisa() is unsynchronized, net.sf.webphotos.gui.component.PainelPesquisa.setAcaoPesquisa(AcaoPesquisa) is synchronized | MT_CORRECTNESS | UG_SYNC_SET_UNSYNC_GET | 165 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in net.sf.webphotos.gui.component.PainelPesquisaBeanInfo.getMdescriptor() | STYLE | REC_CATCH_EXCEPTION | 717 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Empty database password in net.sf.webphotos.tools.TelaResolucao.iniciar() | SECURITY | DMI_EMPTY_DB_PASSWORD | 89 | Medium |
net.sf.webphotos.tools.TelaResolucao.iniciar() may fail to close Connection | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 89 | Medium |
net.sf.webphotos.tools.TelaResolucao.iniciar() may fail to close Statement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 97 | Medium |
Exception is caught when Exception is not thrown in net.sf.webphotos.tools.TelaResolucao.iniciar() | STYLE | REC_CATCH_EXCEPTION | 140 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
net.sf.webphotos.tools.Thumbnail.executaLote() may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 400 | Medium |
net.sf.webphotos.tools.Thumbnail.executaLote() may fail to clean up java.sql.Statement on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 399 | Medium |
Exception is caught when Exception is not thrown in net.sf.webphotos.tools.Thumbnail.estampar(Image) | STYLE | REC_CATCH_EXCEPTION | 225 | Medium |
exceptional return value of java.io.File.delete() ignored in net.sf.webphotos.tools.Thumbnail.save(Image, String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 254 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Empty database password in net.sf.webphotos.tools.XMLExport.main(String[]) | SECURITY | DMI_EMPTY_DB_PASSWORD | 42 | Medium |